annotation: avoid comment conflict warning when irrelevan #10799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gokaysatir
approved these changes
Jan 2, 2025
lpranam
force-pushed
the
comment_conflict
branch
from
ccf7bb3 to
56657f9
Compare
lpranam
force-pushed
the
comment_conflict
branch
2 times, most recently
from
bbae1d9 to
3597f74
Compare
problem: when a user is editing comment and makes some changes to the document text which moves the comment, user used to get comment conflict dialog without any real changes to comment which confused users Signed-off-by: Pranam Lashkari <[email protected]> Change-Id: Ifc6cbe51bc7caecb02a6ac099e6530dded45743b
avoid comment conflict dialog when changes are done by current user itself problem: when autosaved comments are still in edit mode and user undo the comment action user used to get warning "another user removed comment" Signed-off-by: Pranam Lashkari <[email protected]> Change-Id: I8578443f6f4e31f441c9e8ce4c77ec276d9a5d6a
lpranam
force-pushed
the
comment_conflict
branch
from
3597f74 to
6b93209
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay